fix(CLI): diff reports wrong count of changed stacks #26796
Conversation
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
comcalvi
changed the title
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
added
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
removed
the
pr/needs-cli-test-run
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
github-actions
bot
added
bug
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The current logic counts the number of changes in any parent stacks. It doesn't count nested stacks correctly, and doesn't count parent stacks correctly.
With this change:
Without this change:
Closes #26818.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license